Mercurial > hg > early-roguelike
annotate srogue/mdport.c @ 280:70aa5808c782
Fix potential segfaults at restore related to ctime().
In some games, restore() passes the result of ctime() to mvprintw() or
some other variadic message-formatting function. If ctime() has not
been declared properly, its return type is inferred to be int instead
of char *. This does not cause a warning because the compiler does not
know the correct type of variadic arguments.
On platforms where ints and pointers are not the same size, this can,
probably depending on alignment, result in a segfault that is not easy
to trace.
Including time.h fixes the problem. Some games manually declared
ctime() and avoided the bug. These declarations have also been
replaced with the include.
author | John "Elwin" Edwards |
---|---|
date | Fri, 15 Sep 2017 20:51:10 -0400 |
parents | 3d4252fa2ed3 |
children | 8b6aba552f6f |
rev | line source |
---|---|
86 | 1 /* |
2 mdport.c - Machine Dependent Code | |
3 | |
4 Copyright (C) 2005-2008 Nicholas J. Kisseberth | |
5 All rights reserved. | |
6 | |
7 Redistribution and use in source and binary forms, with or without | |
8 modification, are permitted provided that the following conditions | |
9 are met: | |
10 1. Redistributions of source code must retain the above copyright | |
11 notice, this list of conditions and the following disclaimer. | |
12 2. Redistributions in binary form must reproduce the above copyright | |
13 notice, this list of conditions and the following disclaimer in the | |
14 documentation and/or other materials provided with the distribution. | |
15 3. Neither the name(s) of the author(s) nor the names of other contributors | |
16 may be used to endorse or promote products derived from this software | |
17 without specific prior written permission. | |
18 | |
19 THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) AND CONTRIBUTORS ``AS IS'' AND | |
20 ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | |
21 IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | |
22 ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR(S) OR CONTRIBUTORS BE LIABLE | |
23 FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | |
24 DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | |
25 OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | |
26 HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | |
27 LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | |
28 OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | |
29 SUCH DAMAGE. | |
30 */ | |
31 | |
32 #include <stdlib.h> | |
33 #include <string.h> | |
34 | |
35 #if defined(_WIN32) | |
36 #include <Windows.h> | |
37 #include <Lmcons.h> | |
38 #include <io.h> | |
39 #include <conio.h> | |
40 #pragma warning( disable: 4201 ) | |
41 #include <shlobj.h> | |
42 #pragma warning( default: 4201 ) | |
43 #include <Shlwapi.h> | |
44 #undef MOUSE_MOVED | |
191
fb25a62680c7
srogue: clean up configuration in mdport.c.
John "Elwin" Edwards
parents:
190
diff
changeset
|
45 #define HAVE_PROCESS_H |
86 | 46 #endif |
47 | |
118 | 48 #include "rogue.h" |
49 | |
50 #if defined(HAVE_SYS_TYPES) | |
86 | 51 #include <sys/types.h> |
118 | 52 #endif |
53 | |
54 #if defined(HAVE_PROCESS_H) | |
55 #include <process.h> | |
56 #endif | |
57 | |
58 #if defined(HAVE_PWD_H) | |
59 #include <pwd.h> | |
60 #endif | |
61 | |
62 #if defined(HAVE_SYS_UTSNAME) | |
63 #include <sys/utsname.h> | |
64 #endif | |
65 | |
66 #if defined(HAVE_ARPA_INET_H) | |
67 #include <arpa/inet.h> /* Solaris 2.8 required this for htonl() and ntohl() */ | |
68 #endif | |
69 | |
70 #if defined(HAVE_TERMIOS_H) | |
71 #include <termios.h> | |
72 #endif | |
73 | |
74 #if defined(HAVE_UNISTD_H) | |
75 #ifndef __USE_GNU | |
76 #define __USE_GNU | |
77 #include <unistd.h> | |
78 #undef __USE_GNU | |
79 #else | |
80 #include <unistd.h> | |
81 #endif | |
82 #endif | |
86 | 83 |
118 | 84 #if defined(HAVE_TERM_H) |
85 #include <term.h> | |
86 #elif defined(HAVE_NCURSES_TERM_H) | |
87 #include <ncurses/term.h> | |
88 #endif | |
89 | |
90 #if defined(HAVE_WORKING_FORK) | |