Mercurial > hg > early-roguelike
annotate srogue/install-sh @ 111:7f8f43943b1f
Fix some terribly depressing corruption during restore.
In rogue5/state.c, rs_read_daemons() zeroes out the argument and delay
if the daemon slot is empty. Unfortunately that code ended up on the
wrong side of the brace that closes the for loop, so instead of running
after each daemon, it got run once after the loop exited, when the
index was of course out of bounds.
This tended to manifest, when compiled with -O2, by overwriting hw and
setting it to NULL. When inventory() next ran, hw would be passed to
wgetch(), which returns ERR when it gets a NULL argument. This made
md_readchar() think something was wrong and autosave the game.
Upon investigation, rogue3 was found to commit the same mistake.
rogue4 and srogue don't zero the data. arogue5 already does it
properly.
Someday I am going to run all this through Valgrind. Someday when I
am a kinder person who will not be driven to invoke hordes of trolls
and centaurs upon the original authors.
| author | John "Elwin" Edwards |
|---|---|
| date | Wed, 08 Jan 2014 16:44:16 -0500 |
| parents | 15f8229f38c1 |
| children |
| rev | line source |
|---|---|
| 101 | 1 #!/bin/sh |
| 2 # install - install a program, script, or datafile | |
| 3 | |
| 4 scriptversion=2011-11-20.07; # UTC | |
| 5 | |
| 6 # This originates from X11R5 (mit/util/scripts/install.sh), which was | |
| 7 # later released in X11R6 (xc/config/util/install.sh) with the | |
| 8 # following copyright and license. | |
| 9 # | |
| 10 # Copyright (C) 1994 X Consortium | |
| 11 # | |
| 12 # Permission is hereby granted, free of charge, to any person obtaining a copy | |
| 13 # of this software and associated documentation files (the "Software"), to | |
| 14 # deal in the Software without restriction, including without limitation the | |
| 15 # rights to use, copy, modify, merge, publish, distribute, sublicense, and/or | |
| 16 # sell copies of the Software, and to permit persons to whom the Software is | |
| 17 # furnished to do so, subject to the following conditions: | |
| 18 # | |
| 19 # The above copyright notice and this permission notice shall be included in | |
| 20 # all copies or substantial portions of the Software. | |
| 21 # | |
| 22 # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | |
| 23 # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | |
| 24 # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | |
| 25 # X CONSORTIUM BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN | |
| 26 # AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNEC- | |
| 27 # TION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |
| 28 # | |
| 29 # Except as contained in this notice, the name of the X Consortium shall not | |
| 30 # be used in advertising or otherwise to promote the sale, use or other deal- | |
| 31 # ings in this Software without prior written authorization from the X Consor- | |
| 32 # tium. | |
| 33 # | |
| 34 # | |
| 35 # FSF changes to this file are in the public domain. | |
| 36 # | |
| 37 # Calling this script install-sh is preferred over install.sh, to prevent | |
| 38 # 'make' implicit rules from creating a file called install from it | |
| 39 # when there is no Makefile. | |
| 40 # | |
| 41 # This script is compatible with the BSD install script, but was written | |
| 42 # from scratch. | |
| 43 | |
| 44 nl=' | |
| 45 ' | |
| 46 IFS=" "" $nl" | |
| 47 | |
| 48 # set DOITPROG to echo to test this script | |
| 49 | |
| 50 # Don't use :- since 4.3BSD and earlier shells don't like it. | |
| 51 doit=${DOITPROG-} | |
| 52 if test -z "$doit"; then | |
| 53 doit_exec=exec | |
| 54 else | |
| 55 doit_exec=$doit | |
| 56 fi | |
| 57 | |
| 58 # Put in absolute file names if you don't have them in your path; | |
| 59 # or use environment vars. | |
| 60 | |
| 61 chgrpprog=${CHGRPPROG-chgrp} | |
| 62 chmodprog=${CHMODPROG-chmod} | |
| 63 chownprog=${CHOWNPROG-chown} | |
| 64 cmpprog=${CMPPROG-cmp} | |
| 65 cpprog=${CPPROG-cp} | |
| 66 mkdirprog=${MKDIRPROG-mkdir} | |
| 67 mvprog=${MVPROG-mv} | |
| 68 rmprog=${RMPROG-rm} | |
| 69 stripprog=${STRIPPROG-strip} | |
| 70 | |
| 71 posix_glob='?' | |
| 72 initialize_posix_glob=' | |
| 73 test "$posix_glob" != "?" || { | |
| 74 if (set -f) 2>/dev/null; then | |
| 75 posix_glob= | |
| 76 else | |
| 77 posix_glob=: | |
| 78 fi | |
| 79 } | |
| 80 ' | |
| 81 | |
| 82 posix_mkdir= | |
|
15f8229f38c1
srogue: begin porting to autoconf.
John "Elwin" E |
