Mercurial > hg > early-roguelike
comparison srogue/rip.c @ 280:70aa5808c782
Fix potential segfaults at restore related to ctime().
In some games, restore() passes the result of ctime() to mvprintw() or
some other variadic message-formatting function. If ctime() has not
been declared properly, its return type is inferred to be int instead
of char *. This does not cause a warning because the compiler does not
know the correct type of variadic arguments.
On platforms where ints and pointers are not the same size, this can,
probably depending on alignment, result in a segfault that is not easy
to trace.
Including time.h fixes the problem. Some games manually declared
ctime() and avoided the bug. These declarations have also been
replaced with the include.
author | John "Elwin" Edwards |
---|---|
date | Fri, 15 Sep 2017 20:51:10 -0400 |
parents | d3968e9cb98d |
children | 0250220d8cdd |
comparison
equal
deleted
inserted
replaced
279:d3968e9cb98d | 280:70aa5808c782 |
---|---|
16 | 16 |
17 #include <ctype.h> | 17 #include <ctype.h> |
18 #include <string.h> | 18 #include <string.h> |
19 #include <sys/types.h> | 19 #include <sys/types.h> |
20 #include <fcntl.h> | 20 #include <fcntl.h> |
21 #include <time.h> | |
21 #include "rogue.h" | 22 #include "rogue.h" |
22 #include "rogue.ext" | 23 #include "rogue.ext" |
23 | 24 |
24 static char scoreline[100]; | 25 static char scoreline[100]; |
25 | 26 |