Mercurial > hg > early-roguelike
view urogue/TODO @ 313:2f75940cc544
Advanced Rogue 7: fix a string literal overwrite.
pick_spell() attempted to capitalize type by overwriting the first
character, changing it back later. All calls of pick_spell passed a
string literal as type, and string literals should be considered
immutable.
This has been fixed by using a separate variable for the capitalized
first character. XRogue already has a similar fix.
Reported by John Harris of @Play.
| author | John "Elwin" Edwards |
|---|---|
| date | Tue, 19 Oct 2021 20:39:00 -0400 |
| parents | c495a4f288c6 |
| children |
line wrap: on
line source
UltraRogue: The Ultimate Adventure in the Dungeons of Doom Copyright (C) 1993, 1995 Herb Chong All rights reserved. %W% %G% add_pack() calls ur_free() on the linked list pointer passed to it. Need to go through code and look for cases where we use that pointer after calling add_pack(). Electric fence in guard-free() mode should help. Similary throw_away(), discard(), discard_pack() free items... there will be more like this... Bug in genocide scroll: don't request list, type letter, etc... Implement potion of true sight. Bug: apparently when creating a new familiar after a player level change, something isn't begin reset because ur SEGVs when running through the monster list in do_chase() right after the new familiar is created. It appears that the familiar isn't being removed from the monster list.