Mercurial > hg > early-roguelike
view urogue/TODO @ 280:70aa5808c782
Fix potential segfaults at restore related to ctime().
In some games, restore() passes the result of ctime() to mvprintw() or
some other variadic message-formatting function. If ctime() has not
been declared properly, its return type is inferred to be int instead
of char *. This does not cause a warning because the compiler does not
know the correct type of variadic arguments.
On platforms where ints and pointers are not the same size, this can,
probably depending on alignment, result in a segfault that is not easy
to trace.
Including time.h fixes the problem. Some games manually declared
ctime() and avoided the bug. These declarations have also been
replaced with the include.
| author | John "Elwin" Edwards |
|---|---|
| date | Fri, 15 Sep 2017 20:51:10 -0400 |
| parents | c495a4f288c6 |
| children |
line wrap: on
line source
UltraRogue: The Ultimate Adventure in the Dungeons of Doom Copyright (C) 1993, 1995 Herb Chong All rights reserved. %W% %G% add_pack() calls ur_free() on the linked list pointer passed to it. Need to go through code and look for cases where we use that pointer after calling add_pack(). Electric fence in guard-free() mode should help. Similary throw_away(), discard(), discard_pack() free items... there will be more like this... Bug in genocide scroll: don't request list, type letter, etc... Implement potion of true sight. Bug: apparently when creating a new familiar after a player level change, something isn't begin reset because ur SEGVs when running through the monster list in do_chase() right after the new familiar is created. It appears that the familiar isn't being removed from the monster list.