Mercurial > hg > early-roguelike
view xrogue/mach_dep.h @ 280:70aa5808c782
Fix potential segfaults at restore related to ctime().
In some games, restore() passes the result of ctime() to mvprintw() or
some other variadic message-formatting function. If ctime() has not
been declared properly, its return type is inferred to be int instead
of char *. This does not cause a warning because the compiler does not
know the correct type of variadic arguments.
On platforms where ints and pointers are not the same size, this can,
probably depending on alignment, result in a segfault that is not easy
to trace.
Including time.h fixes the problem. Some games manually declared
ctime() and avoided the bug. These declarations have also been
replaced with the include.
author | John "Elwin" Edwards |
---|---|
date | Fri, 15 Sep 2017 20:51:10 -0400 |
parents | 4b1999ac91cf |
children |
line wrap: on
line source
/* mach_dep.h - machine dependents XRogue: Expeditions into the Dungeons of Doom Copyright (C) 1991 Robert Pietkivitch All rights reserved. Based on "Advanced Rogue" Copyright (C) 1984, 1985 Michael Morgan, Ken Dalka and AT&T All rights reserved. Based on "Rogue: Exploring the Dungeons of Doom" Copyright (C) 1980, 1981 Michael Toy, Ken Arnold and Glenn Wichman All rights reserved. See the file LICENSE.TXT for full copyright and licensing information. */ /* * define/undefine that the wizard commands exist */ #ifndef HAVE_CONFIG_H #undef WIZARD #endif #if defined(_WIN32) #define fstat _fstat #define stat _stat #define open _open #define popen _popen #define pclose _pclose #if !defined(__MINGW32__) #define PATH_MAX _MAX_PATH #endif #endif #define NOOP(x) (x += 0) extern char *md_getusername(); extern char *md_gethomedir(); extern char *md_getroguedir(); extern void md_flushinp(); extern char *md_getshell(); extern char *md_gethostname(); extern void md_dobinaryio(); extern char *md_getpass(); extern void md_init(); extern char *xcrypt(); /* * define if you want to limit scores to one per class per userid */ #ifndef HAVE_CONFIG_H /* #define LIMITSCORE 1*/ #undef LIMITSCORE #endif /* * fudge factor allowed in time for saved game */ #define FUDGE_TIME 200 /* File locations. Define here if necessary. */ #if 0 #define SCOREFILE "xrogue.scr" #define LOGFILE "xrogue.log" #endif