Mercurial > hg > early-roguelike
view xrogue/network.h @ 280:70aa5808c782
Fix potential segfaults at restore related to ctime().
In some games, restore() passes the result of ctime() to mvprintw() or
some other variadic message-formatting function. If ctime() has not
been declared properly, its return type is inferred to be int instead
of char *. This does not cause a warning because the compiler does not
know the correct type of variadic arguments.
On platforms where ints and pointers are not the same size, this can,
probably depending on alignment, result in a segfault that is not easy
to trace.
Including time.h fixes the problem. Some games manually declared
ctime() and avoided the bug. These declarations have also been
replaced with the include.
| author | John "Elwin" Edwards |
|---|---|
| date | Fri, 15 Sep 2017 20:51:10 -0400 |
| parents | f54901b9c39b |
| children | 13b482bd9e66 |
line wrap: on
line source
/* network.h - networking setup XRogue: Expeditions into the Dungeons of Doom Copyright (C) 1991 Robert Pietkivitch All rights reserved. Based on "Advanced Rogue" Copyright (C) 1984, 1985 Michael Morgan, Ken Dalka and AT&T All rights reserved. See the file LICENSE.TXT for full copyright and licensing information. */ /* * Note that networking is set up for machines that can communicate * via some system such as uucp. The mechanism listed here uses uux * and assumes that the target machine allows access to the game via * the uux command. NETCOMMAND must be defined if networking is desired. */ /* #undef NETCOMMAND "uux - -n '%s!%s -u' >/dev/null 2>&1" */ /* #define NETCOMMAND "usend -s -d%s -uNoLogin -!'%s -u' - 2>/dev/null" */ #define NETCOMMAND "" /* Networking information -- should not vary among networking machines */ struct network { char *system; char *rogue; }; extern struct network Network[]; extern unsigned long netread(int *error, int size, FILE *stream); extern int netwrite(unsigned long value, int size, FILE *stream);