Mercurial > hg > early-roguelike
view rogue3/INSTALL.txt @ 111:7f8f43943b1f
Fix some terribly depressing corruption during restore.
In rogue5/state.c, rs_read_daemons() zeroes out the argument and delay
if the daemon slot is empty. Unfortunately that code ended up on the
wrong side of the brace that closes the for loop, so instead of running
after each daemon, it got run once after the loop exited, when the
index was of course out of bounds.
This tended to manifest, when compiled with -O2, by overwriting hw and
setting it to NULL. When inventory() next ran, hw would be passed to
wgetch(), which returns ERR when it gets a NULL argument. This made
md_readchar() think something was wrong and autosave the game.
Upon investigation, rogue3 was found to commit the same mistake.
rogue4 and srogue don't zero the data. arogue5 already does it
properly.
Someday I am going to run all this through Valgrind. Someday when I
am a kinder person who will not be driven to invoke hordes of trolls
and centaurs upon the original authors.
author | John "Elwin" Edwards |
---|---|
date | Wed, 08 Jan 2014 16:44:16 -0500 |
parents | c191a735f811 |
children |
line wrap: on
line source
Roguelike Gallery (rlgallery.org) This is the source code for the Roguelike Gallery's version of Rogue V3. History Rogue 3 was released by Michael Toy, Ken Arnold, and Glenn Wichman, probably late in 1980. It went through several minor updates. The last, Rogue 3.6, was completed mid-June 1981. The Roguelike Restoration Project (rogue.rogueforge.net) updated the game to work on modern systems. The Roguelike Gallery's version has been slightly modified for compatibility with dgamelaunch and security for multiple players. Installing Rogue V3 now uses autotools. Run 'autoreconf' and then './configure' to configure for your system. Once that's finished, compile by running make. (I haven't tested the Visual Studio project files on Windows, but they should work.) If you don't use any options with './configure', rogue3 will keep the high score list in whatever directory you run it from. If you just want to play the game yourself, this will work. If you want multi-user play, use the '--enable-setgid' and '--enable-savedir' options to 'configure'. You will also likely want to use '--enable-scorefile' and '--enable-logfile' to set the locations of those files. After compiling, run 'make install'. There are other possible features, including wizard (debugging) mode. To see the full list, run './configure --help'. Playing For more details, see readme36.html (contains the man page) and rogue36.html (Michael Toy's "Guide to the Dungeons of Doom"). Contact rlgallery.org admin: John "Elwin" Edwards <elwin@sdf.org>