Mercurial > hg > early-roguelike
view rogue5/rogue.cat.in @ 111:7f8f43943b1f
Fix some terribly depressing corruption during restore.
In rogue5/state.c, rs_read_daemons() zeroes out the argument and delay
if the daemon slot is empty. Unfortunately that code ended up on the
wrong side of the brace that closes the for loop, so instead of running
after each daemon, it got run once after the loop exited, when the
index was of course out of bounds.
This tended to manifest, when compiled with -O2, by overwriting hw and
setting it to NULL. When inventory() next ran, hw would be passed to
wgetch(), which returns ERR when it gets a NULL argument. This made
md_readchar() think something was wrong and autosave the game.
Upon investigation, rogue3 was found to commit the same mistake.
rogue4 and srogue don't zero the data. arogue5 already does it
properly.
Someday I am going to run all this through Valgrind. Someday when I
am a kinder person who will not be driven to invoke hordes of trolls
and centaurs upon the original authors.
author | John "Elwin" Edwards |
---|---|
date | Wed, 08 Jan 2014 16:44:16 -0500 |
parents | f502bf60e6e4 |
children |
line wrap: on
line source
ROGUE(6) ROGUE(6) NAME rogue - Exploring The Dungeons of Doom SYNOPSIS @PROGRAM@ [ -r ] [ save_file ] [ -s ] [ -d ] DESCRIPTION Rogue is a computer fantasy game with a new twist. It is crt oriented and the object of the game is to survive the attacks of various mon- sters and get a lot of gold, rather than the puzzle solving orientation of most computer fantasy games. To get started you really only need to know two commands. The command ? will give you a list of the available commands and the command / will identify the things you see on the screen. To win the game (as opposed to merely playing to beat other people's high scores) you must locate the Amulet of Yendor which is somewhere below the 20th level of the dungeon and get it out. Nobody has achieved this yet and if somebody does, they will probably go down in history as a hero among heroes. When the game ends, either by your death, when you quit, or if you (by some miracle) manage to win, rogue will give you a list of the top-ten scorers. The scoring is based entirely upon how much gold you get. There is a 10% penalty for getting yourself killed. If save_file is specified, rogue will be restored from the specified saved game file. If the -r option is used, the save game file is pre- sumed to be the default. The -s option will print out the list of scores. The -d option will kill you and try to add you to the score file. For more detailed directions, read the document A Guide to the Dungeons of Doom. AUTHORS Michael C. Toy, Kenneth C. R. C. Arnold, Glenn Wichman FILES @SCOREFILE@ Score file ~/rogue.save Default save file SEE ALSO Michael C. Toy and Kenneth C. R. C. Arnold, A guide to the Dungeons of Doom BUGS Probably infinite (although countably infinite). However, that Ice Monsters sometimes transfix you permanently is not a bug. It's a fea- ture. 4th Berkeley Distribution May 6, 1986 ROGUE(6)