view arogue5/mach_dep.h @ 176:db1c9a21a7c3

srogue: prevent overflowing the score file name. If SCOREFILE is not defined, roguehome() is called to find a directory for the score file. It copies up to PATH_MAX-20 bytes from an environment variable to a static buffer. Later these are strcpy()'d to scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and PATH_MAX is at least 256. On Linux, it happens to be 4096. I haven't yet managed to crash or exploit it, but there are surely no beneficial consequences, so roguehome() has been modified to check the length, and the string it returns is also checked in main().
author John "Elwin" Edwards
date Sun, 02 Aug 2015 12:14:47 -0400
parents dfeed24bb616
children
line wrap: on
line source

/*
 * machine dependicies
 *
 * Advanced Rogue
 * Copyright (C) 1984, 1985 Michael Morgan, Ken Dalka and AT&T
 * All rights reserved.
 *
 * Based on "Rogue: Exploring the Dungeons of Doom"
 * Copyright (C) 1980, 1981 Michael Toy, Ken Arnold and Glenn Wichman
 * All rights reserved.
 *
 * See the file LICENSE.TXT for full copyright and licensing information.
 */

/*
 * Things that get set in config.h have been #if 0'd out.  You should only
 * need to set them here if you don't use configure and want to enable those
 * features.
 */

/*
 * define that the wizard commands exist
 */
#if 0
#undef WIZARD	/*1*/
#endif

/*
 * define if you want to limit scores to one per class per userid
 */
#if 0
#undef LIMITSCORE 
#endif

/*
 * where scorefile should live
 */
#if 0
#define SCOREFILE	"/var/local/games/roguelike/arogue5.scr"
#define LOGFILE		"/var/local/games/roguelike/arogue5.log"
#define SAVEDIR		"/var/local/games/roguelike/arogue5save/"
#endif

/*
 * Variables for checking to make sure the system isn't too loaded
 * for people to play
 */

#if 0
#undef	MAXUSERS	/*40*/	/* max number of users for this game */
#undef	MAXLOAD		/*40*/	/* 10 * max 15 minute load average */
#endif

#undef	CHECKTIME	/*15*/	/* number of minutes between load checks */
				/* if not defined checks are only on startup */

#ifdef MAXLOAD
#define	LOADAV			/* defined if rogue should provide loadav() */

#ifdef LOADAV
#define	NAMELIST	"/unix"	/* where the system namelist lives */
#endif
#endif

#ifdef MAXUSERS
#define	UCOUNT			/* defined if rogue should provide ucount() */

#ifdef UCOUNT
#define UTMP	"/etc/utmp"	/* where utmp file lives */
#endif
#endif

#undef AUTHOR /*212*/

/*
 * define the current author of the program for "special handling"
 */
#ifndef AUTHOR
#define AUTHOR 0	/* Default to root if not specified above */
#endif