Mercurial > hg > early-roguelike
view arogue7/mach_dep.h @ 176:db1c9a21a7c3
srogue: prevent overflowing the score file name.
If SCOREFILE is not defined, roguehome() is called to find a directory
for the score file. It copies up to PATH_MAX-20 bytes from an
environment variable to a static buffer. Later these are strcpy()'d to
scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and
PATH_MAX is at least 256. On Linux, it happens to be 4096.
I haven't yet managed to crash or exploit it, but there are surely no
beneficial consequences, so roguehome() has been modified to check the
length, and the string it returns is also checked in main().
author | John "Elwin" Edwards |
---|---|
date | Sun, 02 Aug 2015 12:14:47 -0400 |
parents | 44a0fce4b168 |
children | 4b1999ac91cf |
line wrap: on
line source
/* * mach_dep.h - machine dependicies * * Advanced Rogue * Copyright (C) 1984, 1985, 1986 Michael Morgan, Ken Dalka and AT&T * All rights reserved. * * Based on "Rogue: Exploring the Dungeons of Doom" * Copyright (C) 1980, 1981 Michael Toy, Ken Arnold and Glenn Wichman * All rights reserved. * * See the file LICENSE.TXT for full copyright and licensing information. */ /* Set these options, if not using config.h */ #ifndef HAVE_CONFIG_H /* * define that the wizard commands exist */ #undef WIZARD /* 0 */ /* * define if you want to limit scores to one per class per userid */ #undef LIMITSCORE /* 1 */ #endif /* * define that rogue should "nice()" itself */ #undef NICE /* 1 */ #ifdef NICE #define FUDGE_TIME 70 /* fudge factor allowed in time for saved game*/ #else #define FUDGE_TIME 50 /* fudge factor allowed in time for saved game*/ #endif #undef DUMP /* 1 */ /* dump core rather than catch the signal */ #undef NOCHECKACCESS /* 1 */ /* If set, then don't check time on save file */ /* * where scorefile should live */ #ifndef HAVE_CONFIG_H #define SCOREFILE "arogue7.scr" #define LOGFILE "arogue7.log" #endif /* * Variables for checking to make sure the system isn't too loaded * for people to play */ #if u370 # define MAXUSERS 40 /* max number of users for this game */ # define MAXPROCESSES 140 /* number processes including system */ /* processes but not including gettys*/ #endif #if uts # define MAXUSERS 45 /* max number of users for this game */ # define MAXPROCESSES 150 /* number processes including system */ /* processes but not including gettys*/ #endif #if vax # define MAXUSERS 17 /* max number of users for this game */ # define MAXPROCESSES 85 /* number processes including system */ /* processes but not including gettys*/ #endif #if u3b # define MAXUSERS 14 /* max number of users for this game */ # define MAXPROCESSES 75 /* number processes including system */ /* processes but not including gettys*/ #endif #undef MAXUSERS #undef MAXPROCESSES #undef CHECKTIME /* 15 *//* number of minutes between load checks */ /* if not defined checks are only on startup */ #define UTMP "/etc/utmp" /* where utmp file lives */ /* * define the current author user id of the program for "special handling" */ #ifndef AUTHOR #define AUTHOR 0 #endif