Mercurial > hg > early-roguelike
view rogue3/machdep.h @ 176:db1c9a21a7c3
srogue: prevent overflowing the score file name.
If SCOREFILE is not defined, roguehome() is called to find a directory
for the score file. It copies up to PATH_MAX-20 bytes from an
environment variable to a static buffer. Later these are strcpy()'d to
scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and
PATH_MAX is at least 256. On Linux, it happens to be 4096.
I haven't yet managed to crash or exploit it, but there are surely no
beneficial consequences, so roguehome() has been modified to check the
length, and the string it returns is also checked in main().
| author | John "Elwin" Edwards |
|---|---|
| date | Sun, 02 Aug 2015 12:14:47 -0400 |
| parents | 07c4d4883ef2 |
| children |
line wrap: on
line source
/* * machine dependicies * * %G% (Berkeley) %W% * * Rogue: Exploring the Dungeons of Doom * Copyright (C) 1980, 1981 Michael Toy, Ken Arnold and Glenn Wichman * All rights reserved. * * See the file LICENSE.TXT for full copyright and licensing information. */ /* * Variables for checking to make sure the system isn't too loaded * for people to play */ /* MAXLOAD and MAXUSERS are now set by configure. */ #define AUTHORUID 0 #if 0 #define MAXUSERS 25 /* max number of users for this game */ #define MAXLOAD 40 /* 10 * max 15 minute load average */ #endif #define CHECKTIME 15 /* number of minutes between load checks */