Mercurial > hg > early-roguelike
view rogue5/list.c @ 176:db1c9a21a7c3
srogue: prevent overflowing the score file name.
If SCOREFILE is not defined, roguehome() is called to find a directory
for the score file. It copies up to PATH_MAX-20 bytes from an
environment variable to a static buffer. Later these are strcpy()'d to
scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and
PATH_MAX is at least 256. On Linux, it happens to be 4096.
I haven't yet managed to crash or exploit it, but there are surely no
beneficial consequences, so roguehome() has been modified to check the
length, and the string it returns is also checked in main().
author | John "Elwin" Edwards |
---|---|
date | Sun, 02 Aug 2015 12:14:47 -0400 |
parents | f502bf60e6e4 |
children |
line wrap: on
line source
/* * Functions for dealing with linked lists of goodies * * @(#)list.c 4.12 (Berkeley) 02/05/99 * * Rogue: Exploring the Dungeons of Doom * Copyright (C) 1980-1983, 1985, 1999 Michael Toy, Ken Arnold and Glenn Wichman * All rights reserved. * * See the file LICENSE.TXT for full copyright and licensing information. */ #include <stdlib.h> #include <curses.h> #include "rogue.h" #ifdef MASTER int total = 0; /* total dynamic memory bytes */ #endif /* * detach: * takes an item out of whatever linked list it might be in */ void _detach(THING **list, THING *item) { if (*list == item) *list = next(item); if (prev(item) != NULL) item->l_prev->l_next = next(item); if (next(item) != NULL) item->l_next->l_prev = prev(item); item->l_next = NULL; item->l_prev = NULL; } /* * _attach: * add an item to the head of a list */ void _attach(THING **list, THING *item) { if (*list != NULL) { item->l_next = *list; (*list)->l_prev = item; item->l_prev = NULL; } else { item->l_next = NULL; item->l_prev = NULL; } *list = item; } /* * _free_list: * Throw the whole blamed thing away */ void _free_list(THING **ptr) { THING *item; while (*ptr != NULL) { item = *ptr; *ptr = next(item); discard(item); } } /* * discard: * Free up an item */ void discard(THING *item) { #ifdef MASTER total--; #endif free(item); } /* * new_item * Get a new item with a specified size */ THING * new_item(void) { THING *item; if ((item = calloc(1, sizeof *item)) == NULL) { #ifdef MASTER msg("ran out of memory after %d items", total); #endif return NULL; } #ifdef MASTER total++; #endif item->l_next = NULL; item->l_prev = NULL; return item; }