Mercurial > hg > early-roguelike
view rogue5/rogue.spec @ 176:db1c9a21a7c3
srogue: prevent overflowing the score file name.
If SCOREFILE is not defined, roguehome() is called to find a directory
for the score file. It copies up to PATH_MAX-20 bytes from an
environment variable to a static buffer. Later these are strcpy()'d to
scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and
PATH_MAX is at least 256. On Linux, it happens to be 4096.
I haven't yet managed to crash or exploit it, but there are surely no
beneficial consequences, so roguehome() has been modified to check the
length, and the string it returns is also checked in main().
| author | John "Elwin" Edwards |
|---|---|
| date | Sun, 02 Aug 2015 12:14:47 -0400 |
| parents | f502bf60e6e4 |
| children |
line wrap: on
line source
Name: rogue Version: 5.4.5 Release: 1%{?dist} Summary: The original graphical adventure game Group: Amusements/Games License: BSD URL: http://rogue.rogueforge.net/ Source0: http://rogue.rogueforge.net/files/rogue5.4/rogue5.4.5-src.tar.gz Source1: rogue.desktop Source2: rogue.png BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: desktop-file-utils BuildRequires: ncurses-devel %description The one, the only, the original graphical adventure game that spawned an entire genre. %prep %setup -q -n %{name}%{version} %build %configure --enable-setgid=games --enable-scorefile=%{_var}/games/roguelike/rogue54.scr --enable-lockfile=%{_var}/games/roguelike/rogue54.lck make %{_smp_mflags} %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT desktop-file-install --vendor fedora \ --dir ${RPM_BUILD_ROOT}%{_datadir}/applications \ %{SOURCE1} mkdir -p $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/32x32/apps/ install -p -m 644 %{SOURCE2} $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/32x32/apps/ %clean rm -rf $RPM_BUILD_ROOT %post touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi %postun touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi %files %defattr(-,root,root,-) %attr(2755,games,games) %{_bindir}/rogue %{_mandir}/man6/rogue.6.gz %{_datadir}/applications/fedora-%{name}.desktop %{_datadir}/icons/hicolor/32x32/apps/rogue.png %dir %attr(0775,games,games) %{_var}/games/roguelike %config(noreplace) %attr(0664,games,games) %{_var}/games/roguelike/rogue54.scr %doc %{_docdir}/%{name}-%{version} %changelog * Sun Aug 24 2008 yendor <yendor at roguefogre.net> 5.4.5-1 - Update to 5.4.5 * Sun Sep 2 2007 Wart <wart at kobold.org> 5.4.4-1 - Update to 5.4.4 * Mon Aug 20 2007 Wart <wart at kobold.org> 5.4.3-1 - Update to 5.4.3 * Sun Jul 15 2007 Wart <wart at kobold.org> 5.4.2-9 - New upstream home page and download URL - Add patch when reading long values from the save file on 64-bit arch (BZ #248283) - Add patch removing many compiler warnings - Use proper version in the .desktop file * Sat Mar 3 2007 Wart <wart at kobold.org> 5.4.2-8 - Use better sourceforge download url - Use more precise desktop file categories * Mon Aug 28 2006 Wart <wart at kobold.org> 5.4.2-7 - Rebuild for Fedora Extras * Tue May 16 2006 Wart <wart at kobold.org> 5.4.2-6 - Added empty initial scoreboard file. * Mon May 15 2006 Wart <wart at kobold.org> 5.4.2-5 - Better setuid/setgid handling (again) (BZ #187392) * Thu Mar 30 2006 Wart <wart at kobold.org> 5.4.2-4 - Better setuid/setgid handling (BZ #187392) - Resize desktop icon to match directory name * Mon Mar 13 2006 Wart <wart at kobold.org> 5.4.2-3 - Added icon for .desktop file. * Sun Mar 12 2006 Wart <wart at kobold.org> 5.4.2-2 - Added missing BR: ncurses-devel, desktop-file-utils * Sat Feb 25 2006 Wart <wart at kobold.org> 5.4.2-1 - Initial spec file.