Mercurial > hg > early-roguelike
view xrogue/mach_dep.h @ 176:db1c9a21a7c3
srogue: prevent overflowing the score file name.
If SCOREFILE is not defined, roguehome() is called to find a directory
for the score file. It copies up to PATH_MAX-20 bytes from an
environment variable to a static buffer. Later these are strcpy()'d to
scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and
PATH_MAX is at least 256. On Linux, it happens to be 4096.
I haven't yet managed to crash or exploit it, but there are surely no
beneficial consequences, so roguehome() has been modified to check the
length, and the string it returns is also checked in main().
author | John "Elwin" Edwards |
---|---|
date | Sun, 02 Aug 2015 12:14:47 -0400 |
parents | 44a0fce4b168 |
children | 4b1999ac91cf |
line wrap: on
line source
/* mach_dep.h - machine dependents XRogue: Expeditions into the Dungeons of Doom Copyright (C) 1991 Robert Pietkivitch All rights reserved. Based on "Advanced Rogue" Copyright (C) 1984, 1985 Michael Morgan, Ken Dalka and AT&T All rights reserved. Based on "Rogue: Exploring the Dungeons of Doom" Copyright (C) 1980, 1981 Michael Toy, Ken Arnold and Glenn Wichman All rights reserved. See the file LICENSE.TXT for full copyright and licensing information. */ /* * define/undefine that the wizard commands exist */ #ifndef HAVE_CONFIG_H #undef WIZARD #endif #if defined(_WIN32) #define fstat _fstat #define stat _stat #define open _open #define popen _popen #define pclose _pclose #if !defined(__MINGW32__) #define PATH_MAX _MAX_PATH #endif #endif #define NOOP(x) (x += 0) extern char *md_getusername(); extern char *md_gethomedir(); extern char *md_getroguedir(); extern void md_flushinp(); extern char *md_getshell(); extern char *md_gethostname(); extern void md_dobinaryio(); extern char *md_getpass(); extern void md_init(); extern char *xcrypt(); /* * define if you want to limit scores to one per class per userid */ #ifndef HAVE_CONFIG_H /* #define LIMITSCORE 1*/ #undef LIMITSCORE #endif /* * fudge factor allowed in time for saved game */ #define FUDGE_TIME 200 /* file locations */ #ifndef HAVE_CONFIG_H #define SCOREFILE "xrogue.scr" #define LOGFILE "xrogue.log" #endif