Mercurial > hg > early-roguelike
view xrogue/network.h @ 176:db1c9a21a7c3
srogue: prevent overflowing the score file name.
If SCOREFILE is not defined, roguehome() is called to find a directory
for the score file. It copies up to PATH_MAX-20 bytes from an
environment variable to a static buffer. Later these are strcpy()'d to
scorefile, which is of size LINLEN. Unfortunately LINLEN is 80 and
PATH_MAX is at least 256. On Linux, it happens to be 4096.
I haven't yet managed to crash or exploit it, but there are surely no
beneficial consequences, so roguehome() has been modified to check the
length, and the string it returns is also checked in main().
| author | John "Elwin" Edwards |
|---|---|
| date | Sun, 02 Aug 2015 12:14:47 -0400 |
| parents | e6179860cb76 |
| children | f54901b9c39b |
line wrap: on
line source
/* network.h - networking setup XRogue: Expeditions into the Dungeons of Doom Copyright (C) 1991 Robert Pietkivitch All rights reserved. Based on "Advanced Rogue" Copyright (C) 1984, 1985 Michael Morgan, Ken Dalka and AT&T All rights reserved. See the file LICENSE.TXT for full copyright and licensing information. */ /* * Note that networking is set up for machines that can communicate * via some system such as uucp. The mechanism listed here uses uux * and assumes that the target machine allows access to the game via * the uux command. NETCOMMAND must be defined if networking is desired. */ /* #undef NETCOMMAND "uux - -n '%s!%s -u' >/dev/null 2>&1" */ /* #define NETCOMMAND "usend -s -d%s -uNoLogin -!'%s -u' - 2>/dev/null" */ #define NETCOMMAND "" /* Networking information -- should not vary among networking machines */ struct network { char *system; char *rogue; }; extern struct network Network[]; extern unsigned long netread(); extern unsigned long netwrite();