RLGWebD: rlgwebd.js comparison

comparison rlgwebd.js @ 47:27b7f0c8b9f0

RLG-Web: make login sessions time out. After enough inactivity, log the user out automatically.

author	John "Elwin" Edwards <elwin@sdf.org>
date	Sat, 09 Jun 2012 21:20:14 -0700
parents	c4efc7522e7b
children	423ef87ddc9b

comparison

equal deleted inserted replaced

-:59ecd99845eb
+:27b7f0c8b9f0
 /* Constructor for TermSessions.  Note that it opens the terminal and
 * adds itself to the sessions dict. It currently assumes the user has
 * been authenticated.
 */
 /* TODO take a callback, or emit success/err events. */
-function TermSession(game, user, dims) {
+function TermSession(game, user, dims, lkey) {
 /* First make sure starting the game will work. */
 if (game in games) {
 this.game = games[game];
 }
 else {
 // TODO: throw an exception instead
 return null;
 }
 this.player = String(user);
+this.key = lkey;
 /* This order seems to best avoid race conditions... */
 this.alive = false;
 this.sessid = randkey(2);
 while (this.sessid in sessions) {
 this.sessid = randkey(2);
 if (!session.alive)
 return;
 fs.fstat(session.record.fd, function (err, stats) {
 if (!err && now - stats.mtime > playtimeout) {
 tslog("Reaping %s", session.sessid);
+/* Dissociate it with its login name. */
+var sn = logins[session.key].sessions.indexOf(session.sessid);
+if (sn >= 0) {
+logins[session.key].sessions.splice(sn, 1);
+if (now - logins[session.key].ts > playtimeout)
+logins[session.key].ts = new Date(now - playtimeout);
+}
+/* Shut it down. */
 session.close();
 }
 });
 }
 for (var sessid in sessions) {
 reapcheck(sessions[sessid]);
+}
+/* HELPME this is about as clever as I can code, so I can't tell whether
+* there are any bugs. */
+for (var lkey in logins) {
+if (logins[lkey].sessions.length == 0) {
+/* A login with no current games can be killed for inactivity. */
+if (now - logins[lkey].ts > playtimeout * 4) {
+tslog("Login for %s (key %s) timed out", logins[lkey].name, lkey);
+delete logins[lkey];
+}
+}
+else {
+/* Check for games that have terminated normally, and update
+* the timestamp. */
+var expired = [];
+var targarray = logins[lkey].sessions;
+/* Let's not find out what happens if you modify an array
+* you're iterating through. */
+for (var i = 0; i < targarray.length; i++) {
+if (!(targarray[i] in sessions))
+expired.push(targarray[i]);
+}
+if (expired.length > 0) {
+logins[lkey].ts = new Date(now);
+for (var j = 0; j < expired.length; j++) {
+targarray.splice(targarray.indexOf(expired[j], 1));
+}
+}
+}
 }
 }
 function login(req, res, formdata) {
 if (!allowlogin) {
 return;
 }
 var lkey = randkey(2);
 while (lkey in logins)
 lkey = randkey(2);
-logins[lkey] = {"name": username, "ts": new Date()};
+logins[lkey] = {"name": username, "ts": new Date(), "sessions": []};
 res.writeHead(200, {'Content-Type': 'application/json'});
 var reply = {"t": "l", "k": lkey, "u": username};
 res.write(JSON.stringify(reply));
 res.end();
 tslog("%s has logged in (key %s)", username, lkey);
 sendError(res, 4, null);
 tslog("%s is already playing %s", username, gname);
 return;
 }
 // Game starting has been approved.
-var nsession = new TermSession(gname, username, dims);
+var nsession = new TermSession(gname, username, dims, lkey);
 if (nsession) {
 res.writeHead(200, {'Content-Type': 'application/json'});
 var reply = {"t": "l", "id": nsession.sessid, "w": nsession.w, "h":
 nsession.h};
 res.write(JSON.stringify(reply));
 res.end();
 tslog("%s playing %s (key %s, pid %d)", username, gname,
 nsession.sessid, nsession.child.pid);
+logins[lkey].sessions.push(nsession.sessid);
 }
 else {
 sendError(res, 5, "Failed to open TTY");
 tslog("Unable to allocate TTY for %s", gname);
 }
 function checkreg(code, signal) {
 if (code === 0) {
 var lkey = randkey(2);
 while (lkey in logins)
 lkey = randkey(2);
-logins[lkey] = {"name": uname, "ts": new Date()};
+logins[lkey] = {"name": uname, "ts": new Date(), "sessions": []};
 var reply = {"t": "r", "k": lkey, "u": uname};
 res.writeHead(200, {'Content-Type': 'application/json'});
 res.write(JSON.stringify(reply));
 res.end();
 tslog("Added new user: %s", uname);