From 090622896b4923615162808c3ae15cb2122c7964 Mon Sep 17 00:00:00 2001 From: "John \"Elwin\" Edwards" Date: Mon, 7 Mar 2016 19:26:08 -0500 Subject: [PATCH] Rogue V4: add two more function declarations. Though it was called with different numbers of arguments, add_line() does not need to be a variadic function. Making the second argument mandatory is a better solution. --- rogue4/rogue.h | 2 ++ rogue4/things.c | 20 ++++++++++---------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/rogue4/rogue.h b/rogue4/rogue.h index 71342f1..fdfa3ff 100644 --- a/rogue4/rogue.h +++ b/rogue4/rogue.h @@ -484,6 +484,7 @@ void _attach(THING **list, THING *item); void _detach(THING **list, THING *item); void _free_list(THING **ptr); bool add_haste(bool potion); +void add_line(char *fmt, char *arg); void add_pack(THING *obj, bool silent); void add_str(str_t *sp, int amt); void addmsg(char *fmt, ...); @@ -515,6 +516,7 @@ bool dropcheck(THING *op); void eat(void); int encread(void *starta, int size, int inf); void encwrite(void *starta, int size, FILE *outf); +void end_line(void); void endmsg(void); void enter_room(coord *cp); void extinguish(void (*func)()); diff --git a/rogue4/things.c b/rogue4/things.c index db6e161..292dba4 100644 --- a/rogue4/things.c +++ b/rogue4/things.c @@ -438,11 +438,11 @@ discovered(void) if (ch == '*') { print_disc(POTION); - add_line(""); + add_line("", NULL); print_disc(SCROLL); - add_line(""); + add_line("", NULL); print_disc(RING); - add_line(""); + add_line("", NULL); print_disc(STICK); end_line(); } @@ -505,7 +505,7 @@ print_disc(char type) num_found++; } if (num_found == 0) - add_line(nothing(type)); + add_line(nothing(type), NULL); } /* @@ -533,9 +533,8 @@ set_order(short *order, int numthings) * add_line: * Add a line to the list of discoveries */ -/* VARARGS1 */ -add_line(fmt, arg) -char *fmt, *arg; +void +add_line(char *fmt, char *arg) { if (line_cnt == 0) { @@ -545,7 +544,7 @@ char *fmt, *arg; } if (slow_invent) { - if (*fmt != '\0') + if (fmt != NULL && *fmt != '\0') msg(fmt, arg); line_cnt++; } @@ -575,7 +574,8 @@ char *fmt, *arg; * end_line: * End the list of lines */ -end_line() +void +end_line(void) { if (!slow_invent) if (line_cnt == 1 && !newpage) @@ -584,7 +584,7 @@ end_line() msg(lastfmt, lastarg); } else - add_line(NULL); + add_line(NULL, NULL); line_cnt = 0; newpage = FALSE; }