Fix some potential problems detected by clang.

Most of these are unnecessary comparisons and functions returning the
wrong types.
This commit is contained in:
John "Elwin" Edwards 2017-09-23 09:47:00 -04:00
parent 614dcfffd2
commit 172c83f254
11 changed files with 24 additions and 25 deletions

View file

@ -200,8 +200,7 @@ main(int argc, char *argv[], char *envp[])
}
if (!use_savedir) {
if ((whoami == NULL) || (*whoami == '\0') ||
(strcmp(whoami,"dosuser")==0))
if ((*whoami == '\0') || (strcmp(whoami,"dosuser")==0))
{
echo();
mvaddstr(23,2,"Rogue's Name? ");
@ -209,7 +208,7 @@ main(int argc, char *argv[], char *envp[])
noecho();
}
if ((whoami == NULL) || (*whoami == '\0'))
if (*whoami == '\0')
strcpy(whoami,"Rodney");
}