Advanced Rogue family: fix some potential buffer overflows.
Some code for determining the score file location assumed that PATH_MAX would be less than 1024, which cannot be guaranteed. Advanced Rogue 5 and 7, and XRogue, have had the buffers for the file name enlarged. UltraRogue never called the functions, so the code has been deleted instead.
This commit is contained in:
parent
2b6d8bcb77
commit
3dfd8fd09b
13 changed files with 51 additions and 78 deletions
|
|
@ -61,6 +61,7 @@ main(int argc, char *argv[], char *envp[])
|
|||
* get home and options from environment
|
||||
*/
|
||||
strncpy(home,md_gethomedir(),LINELEN);
|
||||
home[LINELEN-1] = '\0';
|
||||
|
||||
#ifdef SAVEDIR
|
||||
if (argc >= 3 && !strcmp(argv[1], "-n")) {
|
||||
|
|
@ -82,8 +83,8 @@ main(int argc, char *argv[], char *envp[])
|
|||
}
|
||||
|
||||
#ifdef SCOREFILE
|
||||
strncpy(score_file, SCOREFILE, LINELEN);
|
||||
score_file[LINELEN - 1] = '\0';
|
||||
strncpy(score_file, SCOREFILE, PATH_MAX);
|
||||
score_file[PATH_MAX - 1] = '\0';
|
||||
#else
|
||||
/* Get default score file */
|
||||
strcpy(score_file, roguedir);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue