Mercurial > hg > early-roguelike
view README.txt @ 111:7f8f43943b1f
Fix some terribly depressing corruption during restore.
In rogue5/state.c, rs_read_daemons() zeroes out the argument and delay
if the daemon slot is empty. Unfortunately that code ended up on the
wrong side of the brace that closes the for loop, so instead of running
after each daemon, it got run once after the loop exited, when the
index was of course out of bounds.
This tended to manifest, when compiled with -O2, by overwriting hw and
setting it to NULL. When inventory() next ran, hw would be passed to
wgetch(), which returns ERR when it gets a NULL argument. This made
md_readchar() think something was wrong and autosave the game.
Upon investigation, rogue3 was found to commit the same mistake.
rogue4 and srogue don't zero the data. arogue5 already does it
properly.
Someday I am going to run all this through Valgrind. Someday when I
am a kinder person who will not be driven to invoke hordes of trolls
and centaurs upon the original authors.
| author | John "Elwin" Edwards |
|---|---|
| date | Wed, 08 Jan 2014 16:44:16 -0500 |
| parents | c191a735f811 |
| children | 65f3da34578a |
line wrap: on
line source
This is the source for the Roguelike Gallery's versions of Rogue and other early roguelike games. The code was obtained from the Roguelike Restoration Project (rogue.rogueforge.net). Modifications have been made mainly for compatibility with the dgamelaunch online play system. Some bugs have also been fixed, and the build process slightly improved. The essential flavor of a codebase half as old as stored-program computing machinery remains unchanged. To install on Unix: If you checked out the source from Mercurial, run 'autoreconf' first. Build by running './configure' and then 'make'. If you just want to play the game from your own user account, 'configure' won't need any options. The games will keep the high score lists in whatever directory you run them from. For a multi-user installation, you will need to set the '--enable-setgid', '--enable-savedir', '--enable-scorefile', and '--enable-logfile' options. Run 'make install' after building. There are other possible options; run './configure --help' for a full list. To install on Windows: Use the included Visual Studio solution files. Warning: they have not been tested recently. See the individual games' subdirectories for further documentation. Some of the manpages may be outdated, but the guides to playing should be accurate. The games can be played via SSH or the Web at rlgallery.org. Bugs: The original authors claimed that the list of bugs was "probably infinite". If you encounter one of these, please report it on the bug tracker at https://bitbucket.org/ElwinR/rl.